rosa/lucre
Watch
1
0
Fork
You've already forked lucre
 0
Code Issues 5 Pull requests Releases Activity

Exchange lacks Hash, ExchangeRate lacks Display #12

New issue
Open
opened 2026-08-14 21:13:11 +00:00 by rosa · 0 comments
rosa commented 2026-08-14 21:13:11 +00:00
Owner
Copy link

Two gaps in the traits the types in src/exchange.rs implement.

Exchange does not derive Hash. It derives Clone, Debug, Default, Eq, PartialEq. MoneyBag derives Hash (src/bag.rs:41), and
BTreeMap<K, V>: Hash where both parameters are, so the derive is available.

ExchangeRate does not implement Display. Money, MoneyBag, Currency,
IsoAlphabeticCode and IsoNumericCode all do. A rate therefore cannot appear
in a user-facing message without hand-assembling it from three getters.

Guideline: C-COMMON-TRAITS.

Two gaps in the traits the types in `src/exchange.rs` implement. **`Exchange` does not derive `Hash`.** It derives `Clone, Debug, Default, Eq, PartialEq`. `MoneyBag` derives `Hash` (`src/bag.rs:41`), and `BTreeMap<K, V>: Hash` where both parameters are, so the derive is available. **`ExchangeRate` does not implement `Display`.** `Money`, `MoneyBag`, `Currency`, `IsoAlphabeticCode` and `IsoNumericCode` all do. A rate therefore cannot appear in a user-facing message without hand-assembling it from three getters. Guideline: C-COMMON-TRAITS.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
v0.10.0
v0.9.0
v0.8.0
v0.7.0
v0.6.0
v0.5.1
v0.5.0
v0.4.0
v0.3.0
v0.2.0
v0.1.0
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
rosa/lucre#12
No description provided.