A pair reads text one way where a currency reads two #25
Labels
No labels
kind
bug
kind
enhancement
kind
refactor
workflow
needs-info
workflow
needs-triage
workflow
ready-for-agent
workflow
ready-for-human
workflow
wontfix
No milestone
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
rosa/lucre#25
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Currencyreads text two ways:FromStr(src/lib.rs:1165) andTryFrom<&str>(src/lib.rs:1173), the second delegating to the first. Both"USD".parse::<Currency>()andCurrency::try_from("USD")work, and a callerpicks whichever reads better where they stand.
Pairimplements onlyFromStr(src/exchange/rate.rs:489), soPair::try_from("USD/EUR")fails to compile on the line beneath aCurrency::try_fromthat compiles. The guidelines want both conversions wherethe crate offers either (C-CONV-TRAITS), and the crate has already settled which
shape it prefers one file over.
Additive; nothing breaks.