Into<Pair> turns away a borrowed pair #29
Labels
No labels
kind
bug
kind
enhancement
kind
refactor
workflow
needs-info
workflow
needs-triage
workflow
ready-for-agent
workflow
ready-for-human
workflow
wontfix
No milestone
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
rosa/lucre#29
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
ExchangeRate::new,Exchange::rate, andExchange::remove_ratetakeP: Into<Pair>, so a caller passes a pair or the two currencies and eitherworks. A
&Pairis neither, so walking a&[Pair]or a borrowedVec<Pair>means writing
*pairat every call, or.copied()before the loop.impl From<&Pair> for Paircloses it, sincePairisCopy:Whether it earns its place is the question. The dereference it saves is one
character, and a
From<&T> for Timpl on aCopytype is an oddity that thensits in the rendered docs for everyone reading the type. Filed so the decision is
on the record rather than implied by its absence; closing this as wontfix is a
fine outcome.