The round-trip exactness claim holds only for a flat quotation #53

Closed
opened 2026-08-19 14:50:37 +00:00 by rosa · 0 comments
Owner

What to build

The Quotation docs and ADR 0001 stop promising that converting an amount out of
the base currency and back returns the amount it started with. That holds when
the two prices are equal, and not otherwise.

Both places state it with no condition, in the passage describing a two-way
quotation. A quotation at 0.75/0.8 converts 100 USD to 75.0000 EUR and back to
93.750 USD, short by the spread, which is the reason to quote two ways at all.
The sentence before it — that a round trip comes back at or below where it
started — is already right, and this one contradicts it.

Acceptance criteria

  • The Quotation type docs scope the exactness claim to a quotation that charges nothing, leaving the "at or below where it started" statement as it is.
  • ADR 0001's Consequences section scopes the same claim the same way.
  • The wording agrees with what the round-trip tests already assert.
  • The ADR correction is proposed to the maintainer before it is committed.

Blocked by

None — can start immediately.

## What to build The `Quotation` docs and ADR 0001 stop promising that converting an amount out of the base currency and back returns the amount it started with. That holds when the two prices are equal, and not otherwise. Both places state it with no condition, in the passage describing a two-way quotation. A quotation at 0.75/0.8 converts 100 USD to 75.0000 EUR and back to 93.750 USD, short by the spread, which is the reason to quote two ways at all. The sentence before it — that a round trip comes back at or below where it started — is already right, and this one contradicts it. ## Acceptance criteria - [ ] The `Quotation` type docs scope the exactness claim to a quotation that charges nothing, leaving the "at or below where it started" statement as it is. - [ ] ADR 0001's Consequences section scopes the same claim the same way. - [ ] The wording agrees with what the round-trip tests already assert. - [ ] The ADR correction is proposed to the maintainer before it is committed. ## Blocked by None — can start immediately.
rosa closed this issue 2026-08-20 17:41:12 +00:00
Sign in to join this conversation.
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
rosa/lucre#53
No description provided.