docs: Retire 'claim' from the authorization-code vocabulary #83

Merged

rosa merged 1 commit from domain/authorization-code-vocabulary into main

2026-07-04 02:15:50 +00:00

rosa commented

2026-07-04 02:15:25 +00:00

Owner

Resolves the authorization-code ubiquitous-language drift from #79.

The flow named one concept three ways: redeem (the whole exchange, per the service method and glossary), consume (the atomic single-use removal, per the port method and ADR-0008), and claim — an unanchored synonym for consume introduced by the atomic-consumption change (PR #77).

CONTEXT.md's Authorization Code entry now states the redeem/consume distinction explicitly and lists "claim" under Avoid.
The port doc for consume_authorization_code, the domain service's redemption-path comments, and the Postgres adapter's row-count comment are reworded from claim to consume; the race framing stays, in consume terms.
The conformance behaviours and their both_adapters! wrappers are renamed (consume_claims_the_code_exactly_once → consume_removes_the_code_exactly_once, consume_of_an_unknown_code_claims_nothing → consume_of_an_unknown_code_removes_nothing). Test bodies and assertions are untouched.
ADR-0008 is unchanged; it already speaks the canonical vocabulary.

No behaviour changes. The ci mise task passes.

Closes #79

Resolves the authorization-code ubiquitous-language drift from #79. The flow named one concept three ways: **redeem** (the whole exchange, per the service method and glossary), **consume** (the atomic single-use removal, per the port method and ADR-0008), and **claim** — an unanchored synonym for consume introduced by the atomic-consumption change (PR #77). - CONTEXT.md's **Authorization Code** entry now states the redeem/consume distinction explicitly and lists "claim" under _Avoid_. - The port doc for `consume_authorization_code`, the domain service's redemption-path comments, and the Postgres adapter's row-count comment are reworded from claim to consume; the race framing stays, in consume terms. - The conformance behaviours and their `both_adapters!` wrappers are renamed (`consume_claims_the_code_exactly_once` → `consume_removes_the_code_exactly_once`, `consume_of_an_unknown_code_claims_nothing` → `consume_of_an_unknown_code_removes_nothing`). Test bodies and assertions are untouched. - ADR-0008 is unchanged; it already speaks the canonical vocabulary. No behaviour changes. The `ci` mise task passes. Closes #79

rosa added 1 commit

2026-07-04 02:15:25 +00:00

docs: Retire 'claim' from the authorization-code vocabulary

ci/woodpecker/push/test Pipeline was successful

Details

ci/woodpecker/pr/test Pipeline was successful

Details

c601f432e3

One concept had three names: redeem (the whole exchange), consume (the
atomic single-use removal), and claim — an unanchored synonym for
consume introduced by the atomic-consumption change (PR #77).

Reword the port doc, domain-service comments, and Postgres adapter
comment to say consume where they said claim, rename the conformance
behaviours and their both_adapters! wrappers to match, and extend the
glossary's Authorization Code entry to state the redeem/consume
distinction explicitly, with claim listed under Avoid.

No behaviour changes. Closes #79.

rosa merged commit 17019642d4 into main

2026-07-04 02:15:50 +00:00

rosa deleted branch domain/authorization-code-vocabulary

2026-07-04 02:15:50 +00:00

rosa referenced this pull request from a commit

2026-07-04 02:15:51 +00:00

Merge pull request 'docs: Retire 'claim' from the authorization-code vocabulary' (#83) from domain/authorization-code-vocabulary into main